Partially added support for ARM64 compilation #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I did this small PR to partly add support for compilation under
arm64, I tested on a Linux machine witharm64architecture and it works!Some test fails due to precision being to high but overall it's working.
I modified as well the file
ccore/include/pyclustering/utils/metric.hppadding#include <limits>this should also fix the latest GitHubAction failure.This PR fixes the installation for ARM only with the Build Manually.
Having also the already build package for arm, it involves a big refactor on the whole ci/cd.
If you want I could help you with that. 🚀